Closed
Conversation
florianreuth
requested changes
Jun 10, 2025
Member
florianreuth
left a comment
florianreuth
left a comment
There was a problem hiding this comment.
Thanks for the PR and sorry for the late response; The yaw changes are correct. The fake attach packet causes the 1.8 client not being able to ride the boat at all though (Tested on a Spigot 1.9 server). Can you maybe send a video on before/after your PR on your own server?
florianreuth
pushed a commit
that referenced
this pull request
Jun 27, 2025
Member
|
Let me know in here once you are able to provide a video. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes two changes to improve boats on 1.8/1.7 clients.